mirror of
https://github.com/BigMarc/grammargem.git
synced 2026-10-13 17:01:55 +02:00
Stability (the "super buggy" feel): - Move the Accessibility-tree traversal OFF the main thread with a per-message timeout, so a busy/wedged target app can't beachball or hang GrammaGem. - Replace every unchecked `as! AXUIElement` force-cast with a CFTypeID-checked safe cast (AXSupport), eliminating crashes from misbehaving AX servers. - Never scan GrammaGem's own windows (self-PID exclusion). - Generation tokens + in-flight guard so superseded scans/downloads can't clobber state. Text safety: - Live fixes now read the element's CURRENT value before writing (and only apply a span edit when the field still matches the snapshot), so edits made since the last scan are never overwritten. Cap per-field check length. - Stable per-field identity (AX id / position) so the Live Check list no longer churns. - Include focus + identity in change-detection so tabbing updates the focused field. Other audited fixes: - Page blocker: conservative skip when a browser's URL can't be read. - Model download: validate on-disk size (reject HTML/truncated 200s), clean up partials on cancel/failure, handle URLError.cancelled. - Licensing: clear a server-confirmed-invalid license instead of honoring grace; show the real device limit instead of "0 Macs". - Hotkey re-register falls back to the default if a chosen combo is taken. - Daily free-tier counter tracks the live timezone. - "Fix focused field" ignores non-text controls. Feature: auto-install the on-device model in the background on first launch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
100 lines
4.2 KiB
Swift
100 lines
4.2 KiB
Swift
import Foundation
|
|
import AppKit
|
|
import ApplicationServices
|
|
|
|
/// A text element discovered in the frontmost window via the Accessibility tree.
|
|
struct ScannedField {
|
|
let element: AXUIElement
|
|
let roleName: String
|
|
let label: String
|
|
let text: String
|
|
let isFocused: Bool
|
|
/// Stable-ish identity for SwiftUI: AX identifier if present, else role+label+position.
|
|
let stableID: String
|
|
}
|
|
|
|
/// Walks the Accessibility tree of the frontmost window and collects every
|
|
/// editable text element (text fields, text areas, combo/search boxes) with
|
|
/// content — so GrammaGem can check *all* the text on screen, not just the one
|
|
/// the cursor is in. Bounded so huge web/Electron trees can't stall the app, and
|
|
/// every cross-process message has a timeout so a wedged app can't hang the scan.
|
|
///
|
|
/// Safe to call off the main thread (AXUIElement APIs are thread-safe).
|
|
enum TextFieldScanner {
|
|
static func scan(
|
|
pid: pid_t, focused: AXUIElement?,
|
|
maxFields: Int = 30, maxVisited: Int = 3000
|
|
) -> [ScannedField] {
|
|
let axApp = AXUIElementCreateApplication(pid)
|
|
AX.setMessagingTimeout(axApp, 0.3)
|
|
guard let root = AX.copyElement(axApp, kAXFocusedWindowAttribute)
|
|
?? AX.copyElement(axApp, kAXMainWindowAttribute) else { return [] }
|
|
var out: [ScannedField] = []
|
|
var visited = 0
|
|
walk(root, focused: focused, depth: 0, out: &out, visited: &visited,
|
|
maxFields: maxFields, maxVisited: maxVisited)
|
|
return out
|
|
}
|
|
|
|
private static func walk(
|
|
_ el: AXUIElement, focused: AXUIElement?, depth: Int,
|
|
out: inout [ScannedField], visited: inout Int, maxFields: Int, maxVisited: Int
|
|
) {
|
|
if out.count >= maxFields || visited >= maxVisited || depth > 70 { return }
|
|
visited += 1
|
|
|
|
let role = AX.copyString(el, kAXRoleAttribute) ?? ""
|
|
if role == kAXTextFieldRole as String
|
|
|| role == kAXTextAreaRole as String
|
|
|| role == kAXComboBoxRole as String {
|
|
if let value = AX.copyString(el, kAXValueAttribute),
|
|
value.trimmingCharacters(in: .whitespacesAndNewlines).count >= 3 {
|
|
let label = AX.copyString(el, kAXTitleAttribute)
|
|
?? AX.copyString(el, kAXDescriptionAttribute)
|
|
?? AX.copyString(el, kAXPlaceholderValueAttribute)
|
|
?? roleLabel(role)
|
|
let isFocused = focused != nil && CFEqual(el, focused!)
|
|
out.append(ScannedField(
|
|
element: el, roleName: roleLabel(role),
|
|
label: label, text: value, isFocused: isFocused,
|
|
stableID: identity(of: el, role: role, label: label)))
|
|
}
|
|
}
|
|
|
|
var childrenRef: CFTypeRef?
|
|
if AXUIElementCopyAttributeValue(el, kAXChildrenAttribute as CFString, &childrenRef) == .success,
|
|
let kids = childrenRef as? [AXUIElement] {
|
|
for k in kids {
|
|
if out.count >= maxFields || visited >= maxVisited { break }
|
|
walk(k, focused: focused, depth: depth + 1, out: &out,
|
|
visited: &visited, maxFields: maxFields, maxVisited: maxVisited)
|
|
}
|
|
}
|
|
}
|
|
|
|
/// A SwiftUI-stable identity that survives re-scans and text edits: prefer the
|
|
/// AX identifier, else fall back to role + label + on-screen position.
|
|
private static func identity(of el: AXUIElement, role: String, label: String) -> String {
|
|
if let axID = AX.copyString(el, kAXIdentifierAttribute), !axID.isEmpty {
|
|
return "id:\(axID)"
|
|
}
|
|
var posRef: CFTypeRef?
|
|
if AXUIElementCopyAttributeValue(el, kAXPositionAttribute as CFString, &posRef) == .success,
|
|
let posRef, CFGetTypeID(posRef) == AXValueGetTypeID() {
|
|
var point = CGPoint.zero
|
|
if AXValueGetValue(posRef as! AXValue, .cgPoint, &point) {
|
|
return "pos:\(role)|\(label)|\(Int(point.x)),\(Int(point.y))"
|
|
}
|
|
}
|
|
return "rl:\(role)|\(label)"
|
|
}
|
|
|
|
private static func roleLabel(_ role: String) -> String {
|
|
switch role {
|
|
case kAXTextAreaRole as String: return "Text area"
|
|
case kAXComboBoxRole as String: return "Combo box"
|
|
default: return "Text field"
|
|
}
|
|
}
|
|
}
|